Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Configure browserslist to transpile nested css #1

Merged
merged 3 commits into from
Mar 22, 2025

Conversation

kdy1
Copy link
Contributor

@kdy1 kdy1 commented Mar 13, 2025

My commits are

  1. Configure browserslist to something old, to verify that it's using browserslist.
  2. Enable lightningcss mode for styled-jsx of next.js
  3. Apply fix(styled-jsx): Pass useLightningcss option to styled-jsx correctly vercel/next.js#77008 (need patch commit because it's not merged/published yet)

Copy link

vercel bot commented Mar 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextjs-14-turbo-styled-jsx ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 18, 2025 7:55pm

@kdy1 kdy1 marked this pull request as ready for review March 13, 2025 04:14
@vpontis
Copy link
Owner

vpontis commented Mar 13, 2025

Thanks @kdy1 I messaged you in Slack but this does not work as expected because it's not respecting the browserlist. It's adding & syntax for CSS nesting but that was only introduced in Chrome 120.

@kdy1 kdy1 marked this pull request as draft March 13, 2025 05:10
@vpontis
Copy link
Owner

vpontis commented Mar 22, 2025

Thank you for this PR @kdy1!

@vpontis vpontis merged commit 1aeea71 into vpontis:master Mar 22, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants