-
Notifications
You must be signed in to change notification settings - Fork 509
Merge from vuejs-templates/webpack#develop preserving PWA configuration #150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge from vuejs-templates/webpack#develop preserving PWA configuration #150
Conversation
@NicoCevallos Thanks for the contribution. Can you please break this into multiple PR's according to the way they were merged in Webpack template. Currently it is too big to actually review. Thanks. |
@anubhav7495 I simply compared both repos and move the changes, preserving anything related to PWA in Let me know what do you think. |
@anubhav7495 any news here? It would be really nice to have jest setup in this template too |
@michalsnik As the next version of vue-cli moves to a plugin-based architecture instead of templates, I don't think the PWA template will get new features. With the 3.0 beta coming very soon, the final release is unlikely to take long. |
I know @cristianl, but it will take some time for the new cli to be production ready. And this template already is, so it would be faster to merge those changes anyway. |
@michalsnik Oh, I see – sorry for the 'splaining. |
const path = require('path') | ||
|
||
module.exports = { | ||
dev: { | ||
/ Paths |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing //
Hello there! I should close this PR, right? I guess nobody will find those changes useful with the vue-cli 3. |
Big merge from
vuejs-templates/webpack#develop
Main changes:
webpack-dev-server
. Same intention as the PR 118 that applies the webpack template's PR 975. It adds new dependencies and remove unused dependenciesconnect-history-api-fallback
used intemplate/build/dev-server.js
eventsource-polyfill
used intemplate/build/dev-client.js
express
used intemplate/build/dev-server.js
http-proxy-middleware
used intemplate/build/dev-server.js
opn
used intemplate/build/dev-server.js
webpack-dev-middleware
used intemplate/build/dev-server.js
webpack-hot-middleware
used intemplate/build/dev-client.js
andtemplate/build/dev-server.js
friendly-errors-webpack-plugin
html-webpack-plugin
node-notifier
portfinder
webpack-bundle-analyzer
webpack-dev-server
jest
andyarn
,
or;
for airbnb ESLint preset, due webpack template runslint --fix
if the user select to intall dependencies usingnpm
oryarn
package.json
to:eslint-plugin-vue
to lint HTML Templatespostcss
modulescssnano
it is not present on webpack template, but as it's a dependency ofoptimize-css-assets-webpack-plugin
andcss-loader
, so it is not required on the package.jsonThanks in advance for any review and comment.