Skip to content

If HOST is provided through environment, friendly notification won't display the actual one #1101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tomsseisums opened this issue Nov 23, 2017 · 1 comment

Comments

@tomsseisums
Copy link
Contributor

There is this:

messages: [`Your application is running here: http://${config.dev.host}:${port}`],

If host is provided through environment, this won't get updated and will still display the value found in config, not taking in mind that it could be changed here:

host: process.env.HOST || config.dev.host,

It's a simple fix, though:

messages: [`Your application is running here: http://${devWebpackConfig.devServer.host}:${port}`]

I won't bother with expected/actual behaviour, because the code lines should be simple to follow.


Posted in response to #1099 (comment), because if the switch was made to use internal portfinder of webpack-dev-server this message will most definitely need a check-up.

@LinusBorg LinusBorg added the bug label Nov 23, 2017
@LinusBorg
Copy link
Contributor

LinusBorg commented Nov 23, 2017

Hi @joltmode , thanks for this report, this should indeed be easy to fix.

A PR would be welcome if you are up for it :)

tomsseisums added a commit to tomsseisums/vue-webpack-template that referenced this issue Nov 23, 2017
LinusBorg added a commit that referenced this issue Dec 2, 2017
* develop:
  bump version 1.2.5
  some small updates to the docs
  Adds support for the video poster attribute (#1123)
  babel-register use only for e2e tests (#1120)
  Update project creation: sort dependencies in package.json (#1118)
  Fix bug from PR #1082
  FIX: convert env variable PORT to a number.
  Minor refactoring of build scripts (#1082)
  ESLint config clean up (#1093)
  Switch to uglifyjs-webpack-plugin (#1119)
  change bad spaces into normal spaces and removing trailing space (#1132)
  prevent empty line when unit = y & e2e = n
  Update meta.js (#1091)
  docs(README): Update usage to init from develop branch (#1092)
  Use actual host for notification (#1101). (#1103)
  prevent webpack from injecting useless mocks
frandiox pushed a commit to OnsenUI/vue-cordova-webpack that referenced this issue Dec 25, 2017
shenron pushed a commit to shenron/webpack that referenced this issue Mar 20, 2018
* develop:
  bump version 1.2.5
  some small updates to the docs
  Adds support for the video poster attribute (vuejs-templates#1123)
  babel-register use only for e2e tests (vuejs-templates#1120)
  Update project creation: sort dependencies in package.json (vuejs-templates#1118)
  Fix bug from PR vuejs-templates#1082
  FIX: convert env variable PORT to a number.
  Minor refactoring of build scripts (vuejs-templates#1082)
  ESLint config clean up (vuejs-templates#1093)
  Switch to uglifyjs-webpack-plugin (vuejs-templates#1119)
  change bad spaces into normal spaces and removing trailing space (vuejs-templates#1132)
  prevent empty line when unit = y & e2e = n
  Update meta.js (vuejs-templates#1091)
  docs(README): Update usage to init from develop branch (vuejs-templates#1092)
  Use actual host for notification (vuejs-templates#1101). (vuejs-templates#1103)
  prevent webpack from injecting useless mocks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants