Skip to content

Set ExtractTextPlugin.allChunks to true #1027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 12, 2017
Merged

Set ExtractTextPlugin.allChunks to true #1027

merged 3 commits into from
Nov 12, 2017

Conversation

mgenware
Copy link
Contributor

@mgenware mgenware commented Nov 2, 2017

When using CommonsChunkPlugin and there are extracted chunks (from ExtractTextPlugin.extract) in the commons chunk, allChunks must be set to true。

Doc: https://github.com/webpack-contrib/extract-text-webpack-plugin

@mgenware
Copy link
Contributor Author

mgenware commented Nov 2, 2017

For a quick testing of multiple common chunks, this project may be helpful.

@mgenware mgenware changed the title When using CommonsChunkPlugin and there are extracted chunks (from ExtractTextPlugin.extract) in the commons chunk, allChunks must be set to true Set ExtractTextPlugin.allChunks to true Nov 2, 2017
@LinusBorg
Copy link
Contributor

LinusBorg commented Nov 12, 2017 •
edited
Loading

Hey @mgenware

, so I looked into this, and I don't think that I want to activate this by default.

Reasoning

With the current config, CSS from .vue files that are code-splitted will reside in that async chunk and only be loaded when that async chunk is actually loaded.

That means that the app.css file will be lighter and only contain the "basic" styles, and stuff you load later comes with its own styles.

Solution

I think this option can be useful though, and so I would suggest to add it to the templates config like this:

// set the following options to `true` if you want to extract CSS from
// codesplit chunks into this main css file as well.
// this will result in *all* of your app's CSS being loaded upfront.
allChunks: false

If you want to make this change to your branch, I will merge this so you get credit for bringing this to our attention.s

LinusBorg
LinusBorg suggested changes Nov 12, 2017
View reviewed changes
Copy link
Contributor

@LinusBorg LinusBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my previous comment.

@mgenware
Copy link
Contributor Author

Hi @LinusBorg, thanks for your informative reply. I totally agree, I've committed changes to my branch 😀

@LinusBorg LinusBorg merged commit 626bc98 into vuejs-templates:develop Nov 12, 2017
@LinusBorg LinusBorg added this to the 1.2.0 milestone Nov 12, 2017
c0defre4k added a commit to neonblack-at/webpack that referenced this pull request Nov 17, 2017
@c0defre4k
Merge remote-tracking branch 'vuejs-templates/master'
4a883ef 
* vuejs-templates/master: (54 commits)
  v1.2.3
  remove double FriendlyErrorsPlugin (fix vuejs-templates#1064)
  v 1.2.2
  remove unnecessary minimize option (close vuejs-templates#1056)
  Make sure that imported css files in SFCs are autoprefixed, too (vuejs-templates#1053)
  reduce clientLogLevel
  remove `express` from package.json (vuejs-templates#1060)
  Remove extra commas (vuejs-templates#1050)
  1.2.1 - Bugfix release (vuejs-templates#1052)
  bumb version string in config in package.json
  bumb version string in config
  re-add postcss-loader
  Fix typos and formatting (vuejs-templates#1048)
  fix(jest): fix Jest coverage directory (vuejs-templates#1046)
  Remove unnecessary whitespaces (vuejs-templates#1047)
  re-merge (vuejs-templates#1045)
  Set ExtractTextPlugin.allChunks to true (vuejs-templates#1027)
  pass cssSourceMap option to vue-loader (vuejs-templates#756)
  Grammar and typo fixes on docs (vuejs-templates#992)
  Use webpack 3's standard way to generate a manifest in CommonsChunkPlugin (vuejs-templates#1028)
  ...

# Conflicts:
#	meta.js
#	template/config/index.js
#	template/index.html
#	template/package.json
frandiox pushed a commit to OnsenUI/vue-cordova-webpack that referenced this pull request Dec 25, 2017
@mgenware @frandiox
Set ExtractTextPlugin.allChunks to true (vuejs-templates#1027)
b3bc8e4 
* When using CommonsChunkPlugin and there are extracted chunks (from ExtractTextPlugin.extract) in the commons chunk, allChunks must be set to true
https://github.com/webpack-contrib/extract-text-webpack-plugin

* Explicitly set allChunks to false along with some useful info on codesplit chunks (credit to @LinusBorg)

* Update webpack.prod.conf.js
shenron pushed a commit to shenron/webpack that referenced this pull request Mar 20, 2018
@mgenware @LinusBorg
Set ExtractTextPlugin.allChunks to true (vuejs-templates#1027)
a1b6e64 
* When using CommonsChunkPlugin and there are extracted chunks (from ExtractTextPlugin.extract) in the commons chunk, allChunks must be set to true
https://github.com/webpack-contrib/extract-text-webpack-plugin

* Explicitly set allChunks to false along with some useful info on codesplit chunks (credit to @LinusBorg)

* Update webpack.prod.conf.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinusBorg LinusBorg LinusBorg approved these changes

Assignees
No one assigned
Labels
PR:ready
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mgenware @LinusBorg