Simplify elementCount custom assertions #898
Conversation
Standardize capitalization, punctuation Use common language Reduce word count
Before this commit the term `selector` was used for two separate arguments in two separate scopes. Rename the function passed to the browser so the developer understands that these are two arguments/two scopes/not the same value.
|
Side note: I see a lot of templating to add semicolons. I'm converting all of my code to AirBnb style, and I think it might be possible to write the template files so they can be transformed to the user's preferred formatting (Standard or AirBnB) with a post-install Have you tried that / any interest? It could be a lot cleaner than all of the |
|
tbh I'm not super familiar with Nightwatch, but that change for the callback means that |
|
From what I read in Nightwatch docs, the I'm most interested in making the arguments more clear (c3a2181), so if you'd like to keep the bound callback I can remove the commit that changes it. |
|
@vuejs-templates/collaborators Can anybody with more nightwatch experience chime in wether it's imortant to bind |
|
|
|
@robwierzbowski There's your answer :) |
|
OK, commit removed. Very small PR now :) |
* Improve custom Nightwatch assertion comment readability Standardize capitalization, punctuation Use common language Reduce word count * Clarify elementCount arguments Before this commit the term `selector` was used for two separate arguments in two separate scopes. Rename the function passed to the browser so the developer understands that these are two arguments/two scopes/not the same value.
* Improve custom Nightwatch assertion comment readability Standardize capitalization, punctuation Use common language Reduce word count * Clarify elementCount arguments Before this commit the term `selector` was used for two separate arguments in two separate scopes. Rename the function passed to the browser so the developer understands that these are two arguments/two scopes/not the same value.
* vuejs-templates/master: bump v1.2.4 Simplify elementCount custom assertions (vuejs-templates#898) revert vuejs-templates#996 chunk names to minify prodution JS (vuejs-templates#1086) fix missing comma Batman! add missing cacheBusting option make jest ignore the e2e test folder because its likely to contain files matching the jest's filename pattern Improved Jest config (vuejs-templates#1074) Fix # 1070 When index.html has a positional variable, the error can be printed correctly (vuejs-templates#1071) [enhancement]Remove useless files and performance enhancement in dev server. (vuejs-templates#1072)
* Improve custom Nightwatch assertion comment readability Standardize capitalization, punctuation Use common language Reduce word count * Clarify elementCount arguments Before this commit the term `selector` was used for two separate arguments in two separate scopes. Rename the function passed to the browser so the developer understands that these are two arguments/two scopes/not the same value.
This PR takes care of three things:
selectorin the function passed to the browser is not the same data as theselectorin brackets immediately after it..call().Let me know what you think. #2 was especially confusing to me while I was looking at this file for the first time. If you can think of a better argument name, let me know 🙃.