Skip to content

feat: upgrade prettier #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

FauxFaux
Copy link

@FauxFaux FauxFaux commented May 6, 2020

Literally just bump prettier.

Unfortunately, this brings with it some new defaults, and a load of irrelevant changes. If you want, you can disable trailingComma in .prettierrc, instead?

This is useful to me because it reduces the number of copies of prettier I have to install, as optional in npm doesn't actually mean optional.

@FauxFaux FauxFaux force-pushed the feat/upgrade-prettier branch from 5f4a652 to 6e5ae89 Compare May 6, 2020 22:31
@haoqunjiang
Copy link
Member

See #84 (comment)

Bumping prettier version would mean breaking changes for a whole lot of Vue core packages, including vue-loader and @vue/cli. And as you can see, vue-loader v16 is aimed for Vue 3 support, so we are not going to ship yet another major version for such niche use cases.

In the foreseeable future, I think the only viable solution is to make prettier an optional peer dependency. It would still mean breaking change in this package, though. So might better ship it along with some other planned breaking changes so as not to waste a major version number.

@FauxFaux FauxFaux closed this May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants