Skip to content

fix(observe): solve the Ref not unwrapping on the ssr side issue with recursive way. #723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 2, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 25 additions & 3 deletions src/reactivity/reactive.ts
Original file line number Diff line number Diff line change
Expand Up @@ -127,14 +127,32 @@ export function observe<T>(obj: T): T {

// in SSR, there is no __ob__. Mock for reactivity check
if (!hasOwn(observed, '__ob__')) {
def(observed, '__ob__', mockObserver(observed))
mockReactivityDeep(observed)
}

return observed
}

export function createObserver() {
return observe<any>({}).__ob__
/**
* Mock __ob__ for object recursively
*/
function mockReactivityDeep(obj: any, seen = new WeakMap<any, boolean>()) {
if (seen.has(obj)) return

def(obj, '__ob__', mockObserver(obj))
seen.set(obj, true)

for (const key of Object.keys(obj)) {
const value = obj[key]
if (
!(isPlainObject(value) || isArray(value)) ||
isRaw(value) ||
!Object.isExtensible(value)
) {
continue
}
mockReactivityDeep(value)
}
}

function mockObserver(value: any = {}): any {
Expand All @@ -149,6 +167,10 @@ function mockObserver(value: any = {}): any {
}
}

export function createObserver() {
return observe<any>({}).__ob__
}

export function shallowReactive<T extends object = any>(obj: T): T
export function shallowReactive(obj: any): any {
if (!isObject(obj)) {
Expand Down
3 changes: 1 addition & 2 deletions src/reactivity/set.ts
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,7 @@ export function set<T>(target: AnyObject, key: any, val: T): T {
return val
}
if (!ob) {
// If we are using `set` we can assume that the unwrapping is intended
defineAccessControl(target, key, val)
target[key] = val
return val
}
defineReactive(ob.value, key, val)
Expand Down
16 changes: 16 additions & 0 deletions test/ssr/ssrReactive.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -102,4 +102,20 @@ describe('SSR Reactive', () => {
new: true,
})
})

// #721
it('should behave correctly for the nested ref in the object', () => {
const state = { old: ref(false) }
set(state, 'new', ref(true))
expect(JSON.stringify(state)).toBe(
'{"old":{"value":false},"new":{"value":true}}'
)
})

// #721
it('should behave correctly for ref of object', () => {
const state = ref({ old: ref(false) })
set(state.value, 'new', ref(true))
expect(JSON.stringify(state.value)).toBe('{"old":false,"new":true}')
})
})