Skip to content

fix(runtime-core): provide initialization el when suspence re-mount #10024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

yangxiuxiu1115
Copy link
Contributor

fix #10017 , Maybe I should have an appropriate title, that's my weakness

Copy link

github-actions bot commented Jan 6, 2024

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 89.6 kB (+58 B) 34.1 kB (+22 B) 30.7 kB (+32 B)
vue.global.prod.js 147 kB (+58 B) 53.3 kB (+22 B) 47.6 kB (-26 B)

Usages

Name Size Gzip Brotli
createApp 49.9 kB (+58 B) 19.5 kB (+17 B) 17.8 kB (+32 B)
createSSRApp 53.2 kB (+58 B) 20.8 kB (+17 B) 19 kB (+11 B)
defineCustomElement 52.1 kB (+58 B) 20.3 kB (+17 B) 18.5 kB (+20 B)
overall 63.4 kB (+58 B) 24.5 kB (+17 B) 22.2 kB (+11 B)

@yangxiuxiu1115 yangxiuxiu1115 changed the title fix(runtime-core): fix 10017 fix(runtime-core): provide initialization el when suspence re-mount Jan 7, 2024
@yangxiuxiu1115 yangxiuxiu1115 marked this pull request as draft January 8, 2024 08:27
@yangxiuxiu1115
Copy link
Contributor Author

From the commit perspective, it seems that this part of the code was intentionally removed, so I changed PR to draft

@yangxiuxiu1115 yangxiuxiu1115 marked this pull request as ready for review January 8, 2024 12:20
@yangxiuxiu1115
Copy link
Contributor Author

Updated fix

@yangxiuxiu1115 yangxiuxiu1115 marked this pull request as draft January 8, 2024 13:01
@yangxiuxiu1115 yangxiuxiu1115 marked this pull request as ready for review January 9, 2024 03:41
@yangxiuxiu1115 yangxiuxiu1115 marked this pull request as draft January 9, 2024 03:46
@yangxiuxiu1115 yangxiuxiu1115 deleted the fix/suspence branch January 11, 2024 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash on 'update' non-resolved async component
1 participant