-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
fix(compiler-core): simple identifier should include Chinese #10575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||
---|---|---|---|---|
|
@@ -62,7 +62,7 @@ export function isCoreComponent(tag: string): symbol | void { | |||
} | ||||
} | ||||
|
||||
const nonIdentifierRE = /^\d|[^\$\w]/ | ||||
const nonIdentifierRE = /^\d|[^\$\w\u4e00-\u9fa5]/ | ||||
export const isSimpleIdentifier = (name: string): boolean => | ||||
!nonIdentifierRE.test(name) | ||||
Comment on lines
+65
to
67
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we can refactor this part by using
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. seems that directly use this regx to instead will break other test units |
||||
|
||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add unit test 😁