ci: fix size-report #11203
Merged
ci: fix size-report #11203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ferferga
commented
Jun 23, 2024
ferferga
commented
- Pass PR number as input
- Migrate to thollander/actions-comment-pull-request. It's most used, frequently updated and allows to pass a file directly
* Pass PR number as input * Migrate to thollander/actions-comment-pull-request. It's most used, frequently updated and allows to pass a file directly Signed-off-by: GitHub <[email protected]>
sxzz
approved these changes
Jun 23, 2024
|
Hello @sxzz For some reason, it looks like GitHub is completely skipping the pr_number input. I'm not sure why, but I believe it's due to the formatting of the tag, maybe it not being enclosed in quotes is tripping the actions interpreter. There was also a recent update to the action that I missed that already adds the comment tag as a hidden marker, no need to enclose it in comment markers ourselves. With current workflow, a quote marker would appear below the report. Sorry for all the hassle. I opened #11204 to fix these mistakes. I have a sample run in my fork in case you want to check it as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.