Skip to content

fix(runtime-core): fix HMR static prop does't update #1945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(runtime-core): fix HMR static prop does't update #1945

wants to merge 1 commit into from

Conversation

cool-little-fish
Copy link
Contributor

see issue #1942

@yyx990803
Copy link
Member

Thanks for the PR! It is possible for optimized to be false here if the component happens to be the root node (which means it doesn't have a parent block to enter optimized mode), but still it can have a positive patchFlag.

See 499bc0b

@yyx990803 yyx990803 closed this Aug 24, 2020
@cool-little-fish
Copy link
Contributor Author

cool-little-fish commented Aug 25, 2020 •
edited
Loading

Em... I think if it's a root node update, then there will be no next,

image

so it will never get into updateComponentPreRender function.

@turrsis turrsis mentioned this pull request Jul 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cool-little-fish @yyx990803 @Lucian-4a25