fix(compiler-core): should force dynamic slots when using scope vars in dirs #2568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

HcySunYang wants to merge 1 commit into vuejs:master from HcySunYang:fix-slot-flag

Member

HcySunYang commented Nov 6, 2020

close: #2564


          fix(compiler-core): should force dynamic slots when using scope vars …

1aa922f

…in dirs

Member

yyx990803 commented Nov 30, 2020

The actual cause:

v-on has its own special expression processing (it's skipped in transformExpression)
However, it is not replacing the original exp on the directive node, so the scope ref check is checking the non-processed expression node.

The fix is ensure v-on replaces the original exp with the processed one so the scope ref check can work properly.

yyx990803 closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet