Skip to content

fix(runtime-core/scheduler): should also flush the preFlushCbs when needed #2732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(runtime-core/scheduler): should also flush the preFlushCbs when needed #2732

wants to merge 1 commit into from

Conversation

HcySunYang
Copy link
Member

close: #2730

@HcySunYang HcySunYang closed this Dec 5, 2020
@HcySunYang HcySunYang reopened this Dec 5, 2020
@HcySunYang
Copy link
Member Author

This PR has made some ambiguities, that is, a pre-flush cb is not actually executed before rendering.

@LinusBorg LinusBorg mentioned this pull request Jan 17, 2021
Closed
@LinusBorg
Copy link
Member

@evan this change would allow a normal, pre mode watch() on a template ref to work properly. Do you see any potential issues with this?

@LinusBorg LinusBorg added the need guidance The approach/solution in the PR is unclear and requires guidance from maintainer to proceed further. label Feb 3, 2021
@posva posva mentioned this pull request Feb 4, 2021
Closed
@HcySunYang
Copy link
Member Author

Re-review this, I think it is unreasonable.

@HcySunYang HcySunYang closed this Feb 8, 2021
@gzzhanghao
Copy link
Contributor

Is it better to queue a flush after flushJobs?

if (pendingPreFlushCbs.length) {
  queueFlush()
} else if (queue.length || pendingPostFlushCbs.length) {
  flushJobs(seen)
}

@skirtles-code
Copy link
Contributor

I believe this has now been implemented: b57e995.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
need guidance The approach/solution in the PR is unclear and requires guidance from maintainer to proceed further.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Watch not triggered by changes during rendering
4 participants
@HcySunYang @LinusBorg @gzzhanghao @skirtles-code