chore: set node engine to v16 #4471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As some packages rely on the experimental "stream/web" package only available in node v16.5+, this commit updates the `engines` property to reflect that.
|
Hi @cexbrayat @yyx990803 The LTS version of Node is still 14, is it too forward to directly upgrade it to 16? Currently, many developers still use v14 or even v12, can we consider downgrading it? And for the sake of passing the unit test, we could just use |
|
This is only for the monorepo workspace. Not for published packages. |
|
Thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As some packages rely on the experimental "stream/web" package only available in node v16.5+,
this commit updates the
enginesproperty to reflect that.https://nodejs.org/en/blog/release/v16.5.0/