Skip to content

fix(Transition): should queue update when leave finishes #4941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from

Conversation

edison1105
Copy link
Member

@edison1105 edison1105 commented Nov 12, 2021

Fix #4933

There are two reasons for this

  • First, instance.update doesn't run because it's already in the queue.
  • Secondly, update() needs to be executed after the emptyPlaceholder is mounted, otherwise it will not find the mount container.

@github-actions
Copy link

github-actions bot commented Oct 20, 2023

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB (+2 B) 37.7 kB (+1 B) 33.9 kB (+1 B)
vue.global.prod.js 159 kB (+2 B) 57.6 kB (+1 B) 51.2 kB (+32 B)

Usages

Name Size Gzip Brotli
createApp 55.2 kB 21.2 kB 19.4 kB
createSSRApp 59.1 kB 22.9 kB 20.9 kB
defineCustomElement 59.9 kB 22.8 kB 20.8 kB
overall 68.9 kB (+2 B) 26.3 kB (+1 B) 23.9 kB (+57 B)

@edison1105
Copy link
Member Author

/ecosystem-ci run

@vue-bot
Copy link
Contributor

vue-bot commented Apr 28, 2024

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools success success
nuxt success success
pinia success success
primevue success success
quasar success success
radix-vue success success
router success success
test-utils success success
vant success success
vite-plugin-vue success success
vitepress success success
vue-i18n success success
vue-macros success success
vuetify failure failure
vueuse success success
vue-simple-compiler success success

Copy link

pkg-pr-new bot commented Sep 2, 2024

Open in Stackblitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@4941

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@4941

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@4941

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@4941

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@4941

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@4941

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@4941

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@4941

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@4941

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@4941

vue

pnpm add https://pkg.pr.new/vue@4941

commit: 510a2a0

@edison1105 edison1105 added the ready to merge The PR is ready to be merged. label Sep 2, 2024
@edison1105
Copy link
Member Author

Closing as ##4933 no longer reproduces

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Rejected
Development

Successfully merging this pull request may close these issues.

component with v-if="false" breaks transition mode="out-in"
3 participants