test(e2e): enhance and fix test of svg example #560
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the failing test is expected
I found a bug that is probably caused by
v-model
. I tried but I could't fix it so I add test to cover this issue (the newassertStats
part). Therefore the test of this PR should fail now. I can rebase and push after it's fixed.To reproduce the issue:
For now it can be fixed by adding
key
, but in Vue 2.0key
is not required. (If it is required in Vue 3.0, I can help with fixing the example in this PR)I also add the
assertLabels
which can catch the issue of #552 for regression.The same SVG example in Vue 2.0 passes all the newly added tests.
Changes:
setValue
to more accuratetypeValue
setValue
which will set value and dispatchinput
eventassertLabels
testassertStats
. It didn't assert anything, sorry for my stupid mistake...assertStats
toassertPolygon
because there is a newassertStats