Skip to content

test(e2e): enhance and fix test of svg example #560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 12, 2020

Conversation

CodinCat
Copy link
Contributor

@CodinCat CodinCat commented Dec 23, 2019

Currently the failing test is expected

I found a bug that is probably caused by v-model. I tried but I could't fix it so I add test to cover this issue (the new assertStats part). Therefore the test of this PR should fail now. I can rebase and push after it's fixed.

To reproduce the issue:

  1. Open the svg example
  2. Remove the first range control A
  3. Drag other ranges, they are now broken

For now it can be fixed by adding key, but in Vue 2.0 key is not required. (If it is required in Vue 3.0, I can help with fixing the example in this PR)
I also add the assertLabels which can catch the issue of #552 for regression.

The same SVG example in Vue 2.0 passes all the newly added tests.

Changes:

  • Rename setValue to more accurate typeValue
  • Add setValue which will set value and dispatch input event
  • Add assertLabels test
  • Fix the broken assertStats. It didn't assert anything, sorry for my stupid mistake...
  • Rename assertStats to assertPolygon because there is a new assertStats

@yyx990803 yyx990803 added the 🐞 bug Something isn't working label Dec 30, 2019
@yyx990803 yyx990803 merged commit c7cd386 into vuejs:master Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants