Skip to content

fix(keep-alive): invoke initial activated hook for async components's… #7286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

zhangzhonghe
Copy link
Member

… child component (#7276)

fix #7276

@netlify
Copy link

netlify bot commented Dec 7, 2022

Deploy Preview for vuejs-coverage failed.

Name Link
🔨 Latest commit d296fe5
🔍 Latest deploy log https://app.netlify.com/sites/vuejs-coverage/deploys/63905e39fb11290008287ef4

@yxchai
Copy link

yxchai commented Apr 11, 2023

@yyx990803 , Hi Evan, understanding how busy you are, just want to make sure this PR catch your eyes and if possible, maybe push this a little bit. Thanks!

@vercel
Copy link

vercel bot commented Apr 12, 2023

@zhangzhonghe is attempting to deploy a commit to the vuejs Team on Vercel.

A member of the Team first needs to authorize it.

@719media
Copy link

Would love to have this PR get traction again! Thanks for making this PR!

@Superpat
Copy link

Superpat commented Nov 27, 2023

Just fixed an issue at work that was caused by onActivated not being triggered. This pr has been opened for a while now and all checks seem to pass. Are you lacking manpower to review this or is there another issue ?

It would be nice to be able to remove the duplicated onMounted from our keepalive'd components.

@edison1105
Copy link
Member

/ecosystem-ci run

Copy link

github-actions bot commented Aug 8, 2024

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 90.2 kB (-8.21 kB) 34.6 kB (-2.73 kB) 31.2 kB (-2.42 kB)
vue.global.prod.js 147 kB (-9.18 kB) 54.1 kB (-2.98 kB) 48.1 kB (-2.69 kB)

Usages

Name Size Gzip Brotli
createApp 49.7 kB (-4.27 kB) 19.5 kB (-1.42 kB) 17.8 kB (-1.26 kB)
createSSRApp 53.3 kB (-4.63 kB) 21 kB (-1.56 kB) 19.1 kB (-1.41 kB)
defineCustomElement 51.9 kB (-6.59 kB) 20.2 kB (-2.14 kB) 18.5 kB (-1.89 kB)
overall 63.2 kB (-4.33 kB) 24.5 kB (-1.44 kB) 22.3 kB (-1.3 kB)

@edison1105 edison1105 added the ready for review This PR requires more reviews label Aug 8, 2024
@vue-bot
Copy link
Contributor

vue-bot commented Aug 8, 2024

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools success failure
nuxt failure failure
pinia success success
primevue success success
quasar success success
radix-vue success success
router success success
test-utils success success
vant success success
vite-plugin-vue success success
vitepress success success
vue-i18n success success
vue-macros success failure
vuetify success success
vueuse success success
vue-simple-compiler success success

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review This PR requires more reviews scope: keep-alive
Projects
Status: Needs Review
Development

Successfully merging this pull request may close these issues.

Activated hook is not triggering when mounting childs of an async component
7 participants