Skip to content

test(reactivity): replace isReactive with isReadonly #7513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 4, 2024
Merged

test(reactivity): replace isReactive with isReadonly #7513

merged 1 commit into from
Jun 4, 2024

Conversation

wsypower
Copy link
Contributor

In readonly.spec.ts, use isReadonly to test markRaw instead of isReactive.

@haoqunjiang haoqunjiang added 🧹 p1-chore Priority 1: this doesn't change code behavior. scope: reactivity ready for review This PR requires more reviews labels May 29, 2024
@edison1105 edison1105 added ready to merge The PR is ready to be merged. easy to merge and removed ready for review This PR requires more reviews labels Jun 2, 2024
@yyx990803 yyx990803 merged commit 4caabf2 into vuejs:main Jun 4, 2024
@wsypower wsypower deleted the readonly-test branch June 4, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edison1105 edison1105 edison1105 approved these changes

Assignees
No one assigned
Labels
🧹 p1-chore Priority 1: this doesn't change code behavior. easy to merge ready to merge The PR is ready to be merged. scope: reactivity
Projects
Issue / PR Management
Status: Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wsypower @edison1105 @yyx990803 @haoqunjiang