Skip to content

feat(compiler-sfc): defultAssetUrlOptions add audio tag #7914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

btea
Copy link
Contributor

@btea btea commented Mar 18, 2023

Transforms audio relative asset urls into either imports or absolute urls.

@btea btea changed the title feat: defultAssetUrlOptions add audio tag feat(compiler-sfc): defultAssetUrlOptions add audio tag Mar 18, 2023
@sxzz sxzz added the ready to merge The PR is ready to be merged. label Jun 10, 2023
@pikax
Copy link
Member

pikax commented Oct 19, 2023

@btea can you add a test pls?

@pikax pikax added need test The PR has missing test cases. and removed ready to merge The PR is ready to be merged. labels Oct 19, 2023
Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 87 kB 33.1 kB 29.9 kB
vue.global.prod.js 133 kB 50 kB 44.8 kB

Usages

Name Size Gzip Brotli
createApp 48.4 kB 19 kB 17.4 kB
createSSRApp 51.6 kB 20.3 kB 18.5 kB
defineCustomElement 50.7 kB 19.8 kB 18.1 kB
overall 61.7 kB 23.9 kB 21.8 kB

Copy link

codspeed-hq bot commented Dec 15, 2023

CodSpeed Performance Report

Merging #7914 will not alter performance

⚠️ No base runs were found

Falling back to comparing btea:feat/add-audio-asset-url (e6300dd) with main (0a387df)

Summary

✅ 53 untouched benchmarks

@btea
Copy link
Contributor Author

btea commented Dec 15, 2023

@pikax I've added a test and it works fine locally, I don't know why it goes wrong here. 🤔

@haoqunjiang
Copy link
Member

Closing in favor of #9894

@btea btea deleted the feat/add-audio-asset-url branch May 28, 2024 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need test The PR has missing test cases.
Projects
Status: Rejected
Development

Successfully merging this pull request may close these issues.

4 participants