fix(runtime-core): fix onOnce error #8341
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baiwusanyu-c
changed the title
|
Hi, I have fixed this in #8338 , I think the regex used in parse Name should be modified to fix this. |
|
I only observed the problem of event modifier replacement, thank you for your addition. |
# Conflicts: # packages/runtime-core/__tests__/componentEmits.spec.ts
Size ReportBundles
Usages
|
| // #8342 | ||
| // e.g. emits: { once: null } -> onOnce、ononce | ||
| // Does not require regular expression processing | ||
| key = key.toLowerCase() === 'once' ? key : key.replace(/Once$/, '') |
There was a problem hiding this comment.
Maybe this?
Suggested change
| key = key.toLowerCase() === 'once' ? key : key.replace(/Once$/, '') | |
| key = key.replace(/Once$/, '') || key |
While it is less explicit, it avoids the toLowerCase() call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close: #8342
relate: #8334
Issue exposed by #8334 and doesn't seem to be fixed by 7cc31a5