-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
refactor: replace typeof with type guard #8505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Size ReportBundles
Usages
|
CodSpeed Performance ReportMerging #8505 will improve performances by 73.61%Comparing Summary
Benchmarks breakdown
|
Thanks for the PR - it took a long time for me to decide to close this because I was thinking about how to explain the reasoning. For one - these type guard helpers mainly serve to reduce code size as they minify into a single letter function call compared to the inline A few of these changes (in the compat build's runtime code) might actually make sense, but as a while I don't think this PR is worth it considering the downside of a more noisy git blame history. |
No description provided.