Skip to content

chore: input[type='date'], the modifier number could converted to a timestamp #8687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

shengxinjing
Copy link
Contributor

@shengxinjing shengxinjing commented Jul 1, 2023

when an input element with type="date" or "datetime-local", the modifier number converts 2023-07-01T20:00 and 2023-07-01 to 2023, which is a bit odd and would make sense if it could be converted to a timestamp

String(new Date())
> 'Sat Jul 01 2023 22:19:11 GMT+0800 (China Standard Time)'
Number(new Date())
> 1688221156086

Preview

@shengxinjing shengxinjing changed the title chore: When the input is date or datetime-local, the modifier number… chore: input[type='date'], the modifier number coule converted to a timestamp Jul 1, 2023
@shengxinjing shengxinjing changed the title chore: input[type='date'], the modifier number coule converted to a timestamp chore: input[type='date'], the modifier number could converted to a timestamp Jul 1, 2023
# Conflicts:
#	packages/runtime-dom/src/directives/vModel.ts
@github-actions
Copy link

github-actions bot commented Oct 20, 2023

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 86.6 kB (+161 B) 33 kB (+66 B) 29.7 kB (+22 B)
vue.global.prod.js 133 kB (+161 B) 49.7 kB (+60 B) 44.6 kB (+105 B)

Usages

Name Size Gzip Brotli
createApp 48 kB 18.9 kB 17.2 kB
createSSRApp 51.2 kB 20.2 kB 18.4 kB
defineCustomElement 50.4 kB 19.7 kB 17.9 kB
overall 61.4 kB 23.7 kB 21.6 kB

@netlify
Copy link

netlify bot commented Oct 20, 2023

Deploy Preview for vue-sfc-playground failed.

Name Link
🔨 Latest commit 275342b
🔍 Latest deploy log https://app.netlify.com/sites/vue-sfc-playground/deploys/6532582c000d4800085f3127

@netlify
Copy link

netlify bot commented Oct 20, 2023

Deploy Preview for vue-next-template-explorer failed.

Name Link
🔨 Latest commit 275342b
🔍 Latest deploy log https://app.netlify.com/sites/vue-next-template-explorer/deploys/6532582cf5a7ec00084fd629

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Rejected
Development

Successfully merging this pull request may close these issues.

2 participants