Skip to content

chore: add a time-consuming log for building #8720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

chore: add a time-consuming log for building #8720

wants to merge 2 commits into from

Conversation

shengxinjing
Copy link
Contributor

fyi

sxzz
sxzz reviewed Aug 13, 2023
View reviewed changes
scripts/build.js
@@ -64,7 +65,11 @@ async function run() {
stdio: 'inherit'
}
)
console.log()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why here a empty console.log

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To have an extra blank line in pnpm run build --withTypes

@sxzz sxzz added need discussion 🧹 p1-chore Priority 1: this doesn't change code behavior. labels Aug 31, 2023
@yyx990803
Copy link
Member

Thank you for your PR! However, build script time really isn't something we need to be actively tracking for.

@yyx990803 yyx990803 closed this Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sxzz sxzz sxzz left review comments

Assignees
No one assigned
Labels
🧹 p1-chore Priority 1: this doesn't change code behavior. need discussion
Projects
Triage Session
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shengxinjing @yyx990803 @sxzz