-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
feat(compiler-core): export error message #8729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sxzz
merged 2 commits into
vuejs:3.4
from
shengxinjing:export-error-message-compilercore
Sep 5, 2023
Merged
feat(compiler-core): export error message #8729
sxzz
merged 2 commits into
vuejs:3.4
from
shengxinjing:export-error-message-compilercore
Sep 5, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5f48c93
to
57310a3
Compare
Size ReportBundles
Usages
|
sxzz
approved these changes
Aug 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in code perspective, but we need more discussion
Looks like the bundle size didn't increase. It's tree-shakable. I think the PR is acceptable. |
sxzz
pushed a commit
that referenced
this pull request
Sep 5, 2023
Closed
sxzz
pushed a commit
that referenced
this pull request
Sep 21, 2023
sxzz
pushed a commit
that referenced
this pull request
Sep 22, 2023
sxzz
pushed a commit
that referenced
this pull request
Oct 14, 2023
johnsoncodehk
added a commit
to johnsoncodehk/core
that referenced
this pull request
Oct 14, 2023
This reverts commit be91d43.
sxzz
pushed a commit
that referenced
this pull request
Oct 18, 2023
sxzz
pushed a commit
that referenced
this pull request
Oct 19, 2023
baiwusanyu-c
pushed a commit
to baiwusanyu-c/bwsy-vue-core
that referenced
this pull request
Oct 20, 2023
sxzz
pushed a commit
that referenced
this pull request
Oct 20, 2023
sxzz
pushed a commit
that referenced
this pull request
Oct 23, 2023
yyx990803
pushed a commit
that referenced
this pull request
Oct 25, 2023
sxzz
pushed a commit
that referenced
this pull request
Oct 27, 2023
sxzz
pushed a commit
to baiwusanyu-c/bwsy-vue-core
that referenced
this pull request
Oct 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4537
The dev environment has a more friendly error message when compiling a template that reports an error. But the prod environment has only one error code
we can add error-messages export for better production bug and error report