style: update format & lint config #9162

sxzz · 2023-09-07T07:53:27Z

Changes

add trailing commas
enable sort-imports rule
prefer import node: protocol
enable prefer-ts-expect-error rule
prefer import type & replace import { type A } with import type { A }

style: prefer node: protocol #8584
style: add @typescript-eslint/eslint-plugin plugin #8978
- removed no-unnecessary-type-assertion and consistent-indexed-object-style
style: remove eslint-disable rules #9019

netlify · 2023-09-07T07:54:19Z

❌ Deploy Preview for vue-sfc-playground failed.

Name	Link
🔨 Latest commit	`26424b8`
🔍 Latest deploy log	https://app.netlify.com/sites/vue-sfc-playground/deploys/64f98179fa74660008834b36

netlify · 2023-09-07T07:54:29Z

❌ Deploy Preview for vue-next-template-explorer failed.

Name	Link
🔨 Latest commit	`26424b8`
🔍 Latest deploy log	https://app.netlify.com/sites/vue-next-template-explorer/deploys/64f98179a7092900087a3c10

github-actions · 2023-09-07T13:42:56Z

Size Report

Bundles

File	Size	Gzip	Brotli
runtime-dom.global.prod.js	89.6 kB (+2.48 kB)	34.1 kB (+937 B)	30.7 kB (+804 B)
vue.global.prod.js	147 kB (+13.5 kB)	53.4 kB (+3.39 kB)	47.7 kB (+2.85 kB)

Usages

Name	Size	Gzip	Brotli
createApp	49.7 kB (+1.38 kB)	19.5 kB (+454 B)	17.8 kB (+458 B)
createSSRApp	53.1 kB (+1.47 kB)	20.8 kB (+469 B)	19 kB (+439 B)
defineCustomElement	52 kB (+1.27 kB)	20.2 kB (+426 B)	18.5 kB (+415 B)
overall	63.2 kB (+1.48 kB)	24.4 kB (+528 B)	22.2 kB (+506 B)

sxzz · 2023-09-07T13:49:16Z

Are there any other PRs about stylistic? We can change the base branch to chore/style. /cc @Alfred-Skyblue

Justineo · 2023-09-07T14:28:09Z

.prettierrc

+  "semi": false,
+  "singleQuote": true,
+  "printWidth": 80,
+  "trailingComma": "all",


Why are we making this change?

For convenience and to reduce extra changes in the git history.
If we want to add a new property, we needn't add a comma into the last line, but only add a new line.

I know what trailing commas offer. Just not sure why change this now…additions may not be that frequent at the moment. I’m not against it though.

After discussion, we decided to

work on stylistic PRs that worth merging regularly (like every minor), when most of PRs are merged.

avoid conflicting useful PRs

merge PRs to a branch, and then squash merge to main branch, and add the commit to .git-blame-ignore-revs file.

Alfred-Skyblue · 2023-09-08T00:56:20Z

This is great, we can merge eslint related PRs together.

Alfred-Skyblue · 2023-09-08T08:36:15Z

Are there any other PRs about stylistic? We can change the base branch to chore/style. /cc @Alfred-Skyblue

#9028

sxzz · 2023-09-08T10:07:00Z

@Alfred-Skyblue This PR is actually not about style. We can merge it separately.

codspeed-hq · 2023-12-19T09:15:59Z

CodSpeed Performance Report

Merging #9162 will not alter performance

_{Comparing chore/style (b96fea8) with main (bae79dd)}

Summary

✅ 53 untouched benchmarks

Co-authored-by: 丶远方 <[email protected]> Co-authored-by: 三咲智子 Kevin Deng <[email protected]>

Co-authored-by: Guo Xingjun <[email protected]>

Co-authored-by: 三咲智子 Kevin Deng <[email protected]>

sxzz · 2023-12-26T11:27:38Z

/ecosystem-ci run

vue-bot · 2023-12-26T11:34:55Z

📝 Ran ecosystem CI: Open

suite	result	latest scheduled
language-tools	❌ failure	❌ failure
nuxt	❌ failure	✅ success
pinia	✅ success	✅ success
quasar	✅ success	✅ success
router	✅ success	✅ success
test-utils	✅ success	✅ success
vant	✅ success	✅ success
vite-plugin-vue	❌ failure	✅ success
vitepress	✅ success	❌ failure
vue-i18n	✅ success	✅ success
vue-macros	❌ failure	✅ success
vuetify	❌ failure	✅ success
vueuse	❌ failure	✅ success
vue-simple-compiler	✅ success	✅ success

vue-bot · 2023-12-26T11:39:41Z

📝 Ran ecosystem CI: Open

suite	result	latest scheduled
language-tools	❌ failure	❌ failure
nuxt	❌ failure	✅ success
pinia	❌ failure	✅ success
quasar	✅ success	✅ success
router	✅ success	✅ success
test-utils	✅ success	✅ success
vant	✅ success	✅ success
vite-plugin-vue	✅ success	✅ success
vitepress	✅ success	❌ failure
vue-i18n	✅ success	✅ success
vue-macros	❌ failure	✅ success
vuetify	✅ success	✅ success
vueuse	✅ success	✅ success
vue-simple-compiler	✅ success	✅ success

sxzz marked this pull request as draft September 7, 2023 07:55

Justineo reviewed Sep 7, 2023

View reviewed changes

sxzz force-pushed the chore/style branch from 0414f53 to 77d5928 Compare September 21, 2023 14:07

sxzz force-pushed the chore/style branch 2 times, most recently from 43960c1 to f30bb60 Compare December 19, 2023 09:12

sxzz force-pushed the chore/style branch from b96fea8 to de5f795 Compare December 19, 2023 09:18

sxzz changed the base branch from main to minor December 19, 2023 09:31

sxzz force-pushed the chore/style branch from d133081 to d5df439 Compare December 19, 2023 09:37

sxzz changed the title ~~style: add trailing comma~~ style: update format&lint config Dec 19, 2023

sxzz force-pushed the chore/style branch 6 times, most recently from 8ee5b89 to 8ceb2e5 Compare December 19, 2023 23:14

sxzz marked this pull request as ready for review December 19, 2023 23:16

sxzz force-pushed the chore/style branch 2 times, most recently from ab8ccb5 to abee7f2 Compare December 19, 2023 23:33

sxzz changed the title ~~style: update format&lint config~~ style: update format & lint config Dec 20, 2023

sxzz force-pushed the chore/style branch from e1b51f5 to 827da02 Compare December 20, 2023 10:10

sxzz added 2 commits December 26, 2023 19:14

chore: prettier cfg

ba5820d

fix: prettier files

480b752

sxzz and others added 14 commits December 26, 2023 19:14

chore: remove default value

422f47d

style: prefer node: protocol (#8584)

0b32994

Co-authored-by: 丶远方 <[email protected]> Co-authored-by: 三咲智子 Kevin Deng <[email protected]>

chore: remove unused eslint-disable rules (#9019)

f0dd767

Co-authored-by: Guo Xingjun <[email protected]>

style: add @typescript-eslint/eslint-plugin plugin (#8978)

5834d44

Co-authored-by: 三咲智子 Kevin Deng <[email protected]>

fix: import rules

2afc5a8

feat: add sort imports

136c81a

fix: disable no-unnecessary-type-assertion

97431d6

fix: lint script

e92ed64

fix: remove eslint type-aware

f3f831a

fix: compiler-sfc nodejs-modules

e748930

fix: no-restricted-globals

965d69b

revert: remove eslint disable

e9735d3

style: apply eslint & prettier config

b38b48d

fix: js&tsx

bfe601a

sxzz force-pushed the chore/style branch from 827da02 to bfe601a Compare December 26, 2023 11:27

sxzz merged commit bfe6b45 into minor Dec 26, 2023

sxzz deleted the chore/style branch December 26, 2023 11:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

style: update format & lint config #9162

style: update format & lint config #9162

sxzz commented Sep 7, 2023 •

edited

Loading

netlify bot commented Sep 7, 2023

netlify bot commented Sep 7, 2023

github-actions bot commented Sep 7, 2023 •

edited

Loading

sxzz commented Sep 7, 2023

Justineo Sep 7, 2023

sxzz Sep 7, 2023

Justineo Sep 7, 2023

sxzz Sep 7, 2023

Alfred-Skyblue commented Sep 8, 2023

Alfred-Skyblue commented Sep 8, 2023

sxzz commented Sep 8, 2023 •

edited

Loading

codspeed-hq bot commented Dec 19, 2023

sxzz commented Dec 26, 2023

vue-bot commented Dec 26, 2023

vue-bot commented Dec 26, 2023

style: update format & lint config #9162

style: update format & lint config #9162

Conversation

sxzz commented Sep 7, 2023 • edited Loading

Changes

netlify bot commented Sep 7, 2023

❌ Deploy Preview for vue-sfc-playground failed.

netlify bot commented Sep 7, 2023

❌ Deploy Preview for vue-next-template-explorer failed.

github-actions bot commented Sep 7, 2023 • edited Loading

Size Report

Bundles

Usages

sxzz commented Sep 7, 2023

Justineo Sep 7, 2023

Choose a reason for hiding this comment

sxzz Sep 7, 2023

Choose a reason for hiding this comment

Justineo Sep 7, 2023

Choose a reason for hiding this comment

sxzz Sep 7, 2023

Choose a reason for hiding this comment

Alfred-Skyblue commented Sep 8, 2023

Alfred-Skyblue commented Sep 8, 2023

sxzz commented Sep 8, 2023 • edited Loading

codspeed-hq bot commented Dec 19, 2023

CodSpeed Performance Report

Merging #9162 will not alter performance

Summary

sxzz commented Dec 26, 2023

vue-bot commented Dec 26, 2023

vue-bot commented Dec 26, 2023

sxzz commented Sep 7, 2023 •

edited

Loading

github-actions bot commented Sep 7, 2023 •

edited

Loading

sxzz commented Sep 8, 2023 •

edited

Loading