Skip to content

test(reactivity): should not observe well-known symbol keyed properties in has operation #9174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 6, 2024

Conversation

chenfan0
Copy link
Contributor

@chenfan0 chenfan0 commented Sep 9, 2023

No description provided.

@github-actions
Copy link

github-actions bot commented Sep 9, 2023

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 85.9 kB 32.6 kB 29.5 kB
vue.global.prod.js 132 kB 49.3 kB 44.4 kB

Usages

Name Size Gzip Brotli
createApp 47.9 kB 18.8 kB 17.2 kB
createSSRApp 50.6 kB 19.9 kB 18.2 kB
defineCustomElement 50.3 kB 19.6 kB 17.9 kB
overall 61.2 kB 23.7 kB 21.6 kB

@pikax pikax added the 🧹 p1-chore Priority 1: this doesn't change code behavior. label Oct 20, 2023
@skirtles-code
Copy link
Contributor

Looks good.

For the benefit of anyone else reviewing this...

This is testing an if check in baseHandlers.ts:

if (!isSymbol(key) || !builtInSymbols.has(key)) {
track(target, TrackOpTypes.HAS, key)
}

Currently, all the tests will pass even if that check is changed to if (true). The test added here catches that.

@yyx990803 yyx990803 merged commit 71c2c0a into vuejs:main Jun 6, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧹 p1-chore Priority 1: this doesn't change code behavior.
Projects
Development

Successfully merging this pull request may close these issues.

4 participants