Skip to content

fix(runtime-core): fix errorHandler causes an infinite loop during execution #9575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Mar 19, 2024
Merged
Show file tree
Hide file tree
Changes from 9 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions packages/runtime-core/__tests__/errorHandling.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -583,5 +583,31 @@ describe('error handling', () => {
expect(handler).toHaveBeenCalledTimes(4)
})

// #9574
test('should pause tracking in error handler', async () => {
const error = new Error('error')
const x = ref(Math.random())

const handler = vi.fn(() => {
x.value
x.value = Math.random()
})

const app = createApp({
setup() {
return () => {
throw error
}
}
})

app.config.errorHandler = handler
app.mount(nodeOps.createElement('div'))

await nextTick()
expect(handler).toHaveBeenCalledWith(error, {}, 'render function')
expect(handler).toHaveBeenCalledTimes(1)
})

// native event handler handling should be tested in respective renderers
})
3 changes: 3 additions & 0 deletions packages/runtime-core/src/errorHandling.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import { pauseTracking, resetTracking } from '@vue/reactivity'
import { VNode } from './vnode'
import { ComponentInternalInstance } from './component'
import { warn, pushWarningContext, popWarningContext } from './warning'
Expand Down Expand Up @@ -127,12 +128,14 @@ export function handleError(
// app-level handling
const appErrorHandler = instance.appContext.config.errorHandler
if (appErrorHandler) {
pauseTracking()
callWithErrorHandling(
appErrorHandler,
null,
ErrorCodes.APP_ERROR_HANDLER,
[err, exposedInstance, errorInfo]
)
resetTracking()
return
}
}
Expand Down