Skip to content

fix: stringify targetDir if present #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

fix: stringify targetDir if present #202

wants to merge 2 commits into from

Conversation

luo3house
Copy link
Contributor

@luo3house luo3house commented Nov 30, 2022 •
edited
Loading

Fix #201

The targetDir retrieved from minimist may be a number, and nodejs path.join does not accept number as argument.

@luo3house
Copy link
Contributor Author

luo3house commented Dec 2, 2022 •
edited
Loading

It seems the code is a bit ugly because package minimist provides a string option for argument stringifying. I will open another PR later.

@luo3house luo3house mentioned this pull request Dec 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

npm create vue@3 1 throwsERR_INVALID_ARG_TYPE
1 participant
@luo3house