Skip to content

fix: use a standalone config file for vitest #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 23, 2023

Conversation

btea
Copy link
Collaborator

@btea btea commented Feb 5, 2023

…eport file

fix #221

@btea
Copy link
Collaborator Author

btea commented Feb 19, 2023

@sodatea Please review this pr, thanks.

1. The `template/tsconfig` folder is for `tsconfig.json`s & `package.json`s only;
2. The TS version is identical to `template/config/vitest/vitest.config.js`, so it will be automatically created from the JS template according to the code at https://github.com/vuejs/create-vue/blob/9fde3d1f07a5d5e3792e4c0bf457d6e9f4af4937/index.ts#L380-L392 so this file is redundant.
Copy link
Member

@haoqunjiang haoqunjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the help and sorry for the late review.

The standalone configuration is a bit more verbose than I would like. But so far I haven't found a better solution.

This also seems to be the most scalable way to configure Vitest. So I can settle for it.

@haoqunjiang haoqunjiang changed the title fix: add the configuration and fix the location error of the vitest r… fix: use a standalone config file for the vitest Feb 23, 2023
@haoqunjiang haoqunjiang merged commit 89a8403 into vuejs:main Feb 23, 2023
@haoqunjiang haoqunjiang changed the title fix: use a standalone config file for the vitest fix: use a standalone config file for vitest Feb 23, 2023
@btea btea deleted the fix/report-wrong-position branch February 23, 2023 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vitest - results.json gets created in ./src/node_modules
2 participants