feat: if use playwright, add related extension recommendations #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haoqunjiang
requested changes
May 4, 2023
There was a problem hiding this comment.
Thanks! I like the idea of adding more extension recommendations. But this approach doesn't look scalable to me.
How about putting .vscode/extensions.json in the playwright template folder, and adding a special merging strategy for this file (just like what we already did for package.json). Then we can easily add more extension recommendations (for example, the vitest extension) without adding too much logic code.
|
Good idea! I have updated it. It seems some ci failed. 😕 |
|
No worries, it's just that I messed up the Cypress caches in CI. |
haoqunjiang
approved these changes
May 4, 2023
haoqunjiang
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #248