feat: add Nightwatch for end-to-end testing #257
Conversation
vaibhavsingh97
force-pushed
the
feat/add-nightwatch
branch
from
9f15b3c to
ceee3c1
Compare
|
|
| @@ -0,0 +1,12 @@ | |||
| { | |||
| "extends": "@vue/tsconfig/tsconfig.web.json", | |||
There was a problem hiding this comment.
Should be changed to .dom.json
|
Thanks! The templates look pretty good to me now. So I'd like to cut one more release of |
|
Hi @sodatea, I was wondering if there are any updates I need to make to this PR for it to be merged. |
|
As far as I've tested, the changes are good. The only concern is the implicit hard dependency on the To fix that issue, we need some kind of logical composition for |
The base template has an `vite.config.js.ejs` template file, which reads data from a corresponding `vite.config.js.data.mjs` file. The data file has a default export called `getData()`. Other templates can also have data files that can be chained together so that they can modify the data fed into the template. They don't have to write the template again, though. This fixes the issue mentioned in #257 (comment) As we don't support plugins or extensions for this tool, I didn't choose to design the feature in an extensible way, but only considered ease of implementation and ease of modification.
The base template has a `vite.config.js.ejs` template file, which reads data from a corresponding `vite.config.js.data.mjs` file. The data file has a default export called `getData()`. Other templates can also have data files that can be chained together so that they can modify the data fed into the template. They don't have to define the template again, though. This fixes the issue mentioned in #257 (comment) As we don't support plugins or extensions for this tool, I didn't choose to design the feature in an extensible way, but only considered ease of implementation and ease of modification.
The base template has a `vite.config.js.ejs` template file, which reads data from a corresponding `vite.config.js.data.mjs` file. The data file has a default export called `getData()`. Other templates can also have data files that can be chained together so that they can modify the data fed into the template. They don't have to define the template again, though. This fixes the issue mentioned in vuejs/create-vue#257 (comment) As we don't support plugins or extensions for this tool, I didn't choose to design the feature in an extensible way, but only considered ease of implementation and ease of modification.
Hello 👋 ,
This PR integrates
nightwatchas an end-to-end testing solution for the create-vue CLI. With this integration, developers can quickly write and run automated tests for their Vue applications using the popular nightwatch testing framework.Thank you
cc @sodatea