Skip to content

fix: add cypress install to prepare script to fix pnpm 10 compatibility #679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

haoqunjiang
Copy link
Member

This approach works with both pnpm 10 and other package managers:

  • If Cypress's postinstall script has been run, it'll do nothing other than print a message.
  • If postinstall hasn't been run, it'll download the Cypress binary.

As for why using prepare instead of postinstall, please refer to the discussion thread where husky decided to use prepare:

…bility

This approach works with both pnpm 10 and other package managers:
- If Cypress's `postinstall` script has been run, it'll do nothing other
than print a message.
- If `postinstall` hasn't been run, it'll download the Cypress binary.

As for why using `prepare` instead of `postinstall`, please refer to the
discussion thread where `husky` decided to use `prepare`:
- <typicode/husky#884>
@cexbrayat cexbrayat merged commit 3def8a9 into vuejs:main Feb 6, 2025
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants