Skip to content

Navbar on top of Vue mastery banner on mobile #1846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hichemfantar opened this issue Jul 21, 2022 · 4 comments · Fixed by #1850
Closed

Navbar on top of Vue mastery banner on mobile #1846

hichemfantar opened this issue Jul 21, 2022 · 4 comments · Fixed by #1850

Comments

@hichemfantar
Copy link
Contributor

hichemfantar commented Jul 21, 2022 •
edited
Loading

Only happens when I scroll
Screenshot_20220721-115512.jpg
@xfq
Copy link
Contributor

xfq commented Jul 21, 2022

It's probably because the z-order of the VPNav component is larger than the Vue Mastery banner.

@hichemfantar
Copy link
Contributor Author

Will attempt a PR.

@xfq
Copy link
Contributor

xfq commented Jul 21, 2022

FYI - the banner component is in https://github.com/vuejs/docs/blob/main/.vitepress/theme/components/VueMasteryBanner.vue

hichemfantar added a commit to hichemfantar/docs that referenced this issue Jul 22, 2022
@hichemfantar
Fix vue mastery banner z-order
bd227b6 
closes vuejs#1846
@hichemfantar hichemfantar mentioned this issue Jul 22, 2022
Merged
@hichemfantar
Copy link
Contributor Author

This pr should fix it.

NataliaTepluhina pushed a commit that referenced this issue Jul 22, 2022
@hichemfantar
Fix vue mastery banner z-order (#1850)
76526bf 
closes #1846
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix vue mastery banner z-order hichemfantar/docs
2 participants
@xfq @hichemfantar