-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Fix for #1691 #1699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for #1691 #1699
Conversation
According to previous steps an <a href=""> where used where as in step vuejs#15 used markdown based links [Examples](/examples) which somehow caused 404.
✅ Deploy Preview for vuejs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
Could you remove the spaces between the tags and their content? It's pushing the linked text away from the adjacent punctuation (see https://deploy-preview-1699--vuejs.netlify.app/tutorial/#step-15).
I'm unclear what's causing the broken links. Do you have any insight into that? Your fix is consistent with some of the other steps, I just don't understand why it's happening in the first place.
I would wager it is due to createMarkdownRenderer from vitepress, since i dont understand most of the code, i think it is because of a missing base string => in https://github.com/vuejs/docs/blob/main/src/tutorial/tutorial.data.ts which accepts 3 params: srcDir, options and base |
By changing the const md in /tutorial/tutorial.data.ts (added , '/' )
Should I commit it along with the current pull request? |
I think simply adding the missing base to |
Pushed the fix for createMarkdownRenderer which made it possible to use markdown links again. |
Description of Problem
404 errors on the links in /tutorials/#step-15
Proposed Solution
Changing the links from markdown based links
[]() to <a href="">
like in the previous stepsAdditional Information
Tough unrelated, it is my first time committing to an open source.