Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Caveats about props in TS with Options API #1853

Merged
merged 1 commit into from
Jul 25, 2022

Conversation

chunjin666
Copy link
Contributor

@chunjin666 chunjin666 commented Jul 24, 2022

The Document URL is : https://vuejs.org/guide/typescript/options-api.html#typing-component-props

Description of Problem

The caveats explaination of type inference problem need to update because it has been improved by TypeScript.
TypeScript release notes 4.7
TypeScript PR #48538

Proposed Solution

Add additional instructions of TypeScript version.

Additional Information

No more.

The inference limit of TypeScript has been improved in TypeScript 4.7. MR:
microsoft/TypeScript#48538
@netlify
Copy link

netlify bot commented Jul 24, 2022

Deploy Preview for vuejs ready!

Name Link
🔨 Latest commit 2962f47
🔍 Latest deploy log https://app.netlify.com/sites/vuejs/deploys/62dd0dd39a03170008f2f628
😎 Deploy Preview https://deploy-preview-1853--vuejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@NataliaTepluhina NataliaTepluhina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chunjin666 thank you! This is a really nice fix 👍🏻

@NataliaTepluhina NataliaTepluhina merged commit 58844c0 into vuejs:main Jul 25, 2022
chunjin666 added a commit to chunjin666/docs-zh-cn that referenced this pull request Jul 25, 2022
同步英文文档此处关于 prop 注意事项的更新
vuejs/docs#1853
wxsms added a commit to vuejs-translations/docs-zh-cn that referenced this pull request Jul 26, 2022
* Update options-api.md

同步英文文档此处关于 prop 注意事项的更新
vuejs/docs#1853

* Apply suggestions from code review

Co-authored-by: wxsm <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants