Skip to content

docs: added events as props and typing with object based emits #2583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

pikax
Copy link
Member

@pikax pikax commented Nov 30, 2023

Description of Problem

Document typing parameters when using emits options syntax.

Also document of declaring emits via props.

Copy link

netlify bot commented Nov 30, 2023

Deploy Preview for vuejs ready!

Name Link
🔨 Latest commit 45db874
🔍 Latest deploy log https://app.netlify.com/sites/vuejs/deploys/656996bf15bb180008c3ca3c
😎 Deploy Preview https://deploy-preview-2583--vuejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@NataliaTepluhina NataliaTepluhina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pikax thank you for the PR! I've added a few styling suggestions for your consideration

pikax and others added 2 commits November 30, 2023 16:12
Copy link
Member

@NataliaTepluhina NataliaTepluhina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Carlos, this looks great 🎉

@NataliaTepluhina NataliaTepluhina merged commit 48ea900 into vuejs:main Dec 1, 2023
@pikax pikax deleted the advance_usage_of_events_and_options_type branch December 1, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants