Skip to content

style: fix Special Sponsor loading #2590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Conversation

the-pesar
Copy link
Contributor

Description of Problem

Special Sponsor section is really messy
Screenshot from 2023-12-05 22-06-36

Copy link

netlify bot commented Dec 5, 2023

Deploy Preview for vuejs ready!

Name Link
🔨 Latest commit 20060f5
🔍 Latest deploy log https://app.netlify.com/sites/vuejs/deploys/656f711e0c8d4c0008de542b
😎 Deploy Preview https://deploy-preview-2590--vuejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@NataliaTepluhina NataliaTepluhina merged commit 6f67576 into vuejs:main Dec 6, 2023
@Jinjiang
Copy link
Member

FYI: in Chinese doc site, we added a sponsorship welcome link with a v-else-if="data" dir if the sponsor list is empty.

https://github.com/vuejs-translations/docs-zh-cn/blob/main/.vitepress/theme/components/Home.vue#L89:L91

which I think might be a better practice. Also the template structure could be more reused (since now to keep the link on Chinese doc site, the template structure becomes different from the English one).

Thanks.

Skatox added a commit to Skatox/vuejs-spanish-docs that referenced this pull request May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants