Skip to content

Add codepens instead of example Vue components (part 1) #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 3, 2020
Merged

Add codepens instead of example Vue components (part 1) #57

merged 8 commits into from
Apr 3, 2020

Conversation

NataliaTepluhina
Copy link
Member

@NataliaTepluhina NataliaTepluhina commented Mar 15, 2020 •
edited
Loading

This PR is moving a part of our example Vue components to codepens and implements multiple fixes to existing docs.

What is done

I'm splitting the work on adding codepens intentionally, otherwise, this PR will become too large to review it thoroughly.

Follow-up MR to continue this work: #60

@NataliaTepluhina NataliaTepluhina added the enhancement New feature or request label Mar 15, 2020
@NataliaTepluhina
Copy link
Member Author

Codepens style is a subject to discuss of course 😅

If we decide to use codepens, I will continue migration in this PR

@phanan
Copy link
Member

phanan commented Mar 15, 2020 •
edited
Loading

Great work! Should we take this chance to "rename" the apps to something other than the meaningless App(n)? I'm thinking about more declarative names (and with them, corresponding DOM ID's) like HelloVueApp or ElementBindingApp etc.

@NataliaTepluhina
Copy link
Member Author

@phanan omg that's a great idea! 👍 I am all up for it

@NataliaTepluhina NataliaTepluhina changed the title WIP: Add codepens instead of example Vue components Add codepens instead of example Vue components (part 1) Mar 22, 2020
@NataliaTepluhina
Copy link
Member Author

@sdras @znck @bencodezen @phanan @shentao could you please review this one? I've just resolved WIP status 😅

@NataliaTepluhina NataliaTepluhina mentioned this pull request Mar 24, 2020
Merged
@NataliaTepluhina NataliaTepluhina added this to the alpha milestone Mar 24, 2020
@NataliaTepluhina NataliaTepluhina mentioned this pull request Mar 24, 2020
Closed
@NataliaTepluhina NataliaTepluhina merged commit c4969ee into master Apr 3, 2020
@NataliaTepluhina NataliaTepluhina deleted the test-codepen branch May 4, 2020 04:18
@Xenonym Xenonym mentioned this pull request Jun 22, 2021
Merged
skirtles-code pushed a commit that referenced this pull request Jun 22, 2021
@Xenonym
chore: remove axios (#1104)
4ee1ff2 
axios was added in #31, but is now unused as code examples were moved
to CodePen in #57.

Let's remove axios.
moHaHa pushed a commit to moHaHa/vuejs-docs that referenced this pull request May 4, 2023
@Abdelaziz18003
Merge pull request vuejs#57 from boussadjra/feat/introduction
cbd9ad7 
Feat/introduction
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bencodezen bencodezen Awaiting requested review from bencodezen

@phanan phanan Awaiting requested review from phanan

@sdras sdras Awaiting requested review from sdras

@znck znck Awaiting requested review from znck

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
alpha
Development

Successfully merging this pull request may close these issues.
2 participants
@NataliaTepluhina @phanan