Skip to content

3.9.0 try to check js file with vue rules and broke down #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
deangoku opened this issue Aug 4, 2017 · 4 comments · Fixed by #127
Closed

3.9.0 try to check js file with vue rules and broke down #125

deangoku opened this issue Aug 4, 2017 · 4 comments · Fixed by #127
Labels

Comments

@deangoku
Copy link

deangoku commented Aug 4, 2017

Tell us about your environment

  • **ESLint Version: 4.3.0
  • **eslint-plugin-vue Version: 3.9.0
  • **Node Version: 6.11.2

Please show your full configuration:

// http://eslint.org/docs/user-guide/configuring
module.exports = {
  root: true,
  // https://github.com/feross/standard/blob/master/RULES.md#javascript-standard-style
  extends: ['standard', 'plugin:vue/recommended'],
  parserOptions: {
    parser: 'babel-eslint',
    sourceType: 'module'
  },
  env: {
    browser: true
  },
  // add your custom rules here
  rules: {
    // allow paren-less arrow functions
    'arrow-parens': 0,
    // allow async-await
    'generator-star-spacing': 0,
    // allow debugger during development
    'no-debugger': process.env.NODE_ENV === 'production' ? 2 : 0,
    // allow shorthand for method definitions
    'space-before-function-paren': 0
  }
}

What did you do? Please include the actual source code causing the issue.

npm up

What did you expect to happen?
eslint-plugin-vue upgrade from 3.8.0 to 3.9.0 and work well
What actually happened? Please include the actual, raw output from ESLint.
totally broke down. 3.9.0 try to check js file with vue rules……
image

@mysticatea
Copy link
Member

mysticatea commented Aug 4, 2017

Thank you for the report.

However, I could not reproduce it.
Could you tell me the repro steps?

I found it.

@afontcu
Copy link
Member

afontcu commented Aug 4, 2017

Hi,

I don't know if this is related, but since I upgraded to 3.9.0 the Use the latest vue-eslint-parser message appeared again even though I already placed babel-eslint inside the parserOptions object (and it was working properly with prior versions of eslint-plugin-vue).

Thanks!

@mysticatea mysticatea added bug and removed needs info labels Aug 4, 2017
@mysticatea
Copy link
Member

@afontcu That was it. I will fix. Thank you.

@michalsnik
Copy link
Member

Fixed in v3.10.0. Let us know if you still have any issues.

filipalacerda pushed a commit to filipalacerda/eslint-plugin-vue that referenced this issue Aug 5, 2017
* master:
  Add rule `vue/require-valid-default-prop`. (vuejs#119)
  3.10.0
  Update readme to 3.10.0
  Chore: remove package-lock.json (vuejs#128)
  Fix: parserService must exist always (fixes vuejs#125) (vuejs#127)
  Add rule `require-render-return`. (vuejs#114)
  3.9.0
  Update package-lock
  Update: options for `no-duplicate-attributes` (fixes vuejs#112)(vuejs#113)
  New: add rule `attribute-hyphenation`. (fixes vuejs#92)(vuejs#95)
  Add namespace check of svg & mathML instead of tag names (vuejs#120)
  ⚠️ Add support for deprecated state in update-rules ⚠️ (vuejs#121)
  Add rules: `no-dupe-keys` and `no-reserved-keys`. (vuejs#88)
  Chore: Improve tests for name-property-casing & improve documentation (vuejs#115)
  New: add `require-prop-types` rule (fixes vuejs#19)(vuejs#85)
  Update: upgrade vue-eslint-parser (fixes vuejs#36, fixes vuejs#56, fixes vuejs#96) (vuejs#116)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants