-
-
Notifications
You must be signed in to change notification settings - Fork 681
attributes-order doesn't specify where slot-scope goes. #432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Related to this, I'd have expected the |
Should something be done for |
Just realised my 'fix' of binding |
Just noticed the tests for this rule don't cover the |
Thanks for posting this issue and working on it @GufNZ! Let me know once it's ready so I can review :) Let's leave |
@michalsnik The PR fixes just that, and I was going to make sure the tests cover the new change, but they don't yet cover |
Tell us about your environment
Please show your full configuration: N/A
What did you do? Please include the actual source code causing the issue.
I have a template that uses a component supporting scoped slots, but the rule
vue/attributes-order
does not specify where theslot-scope
attribute should go and treats it like a normal attribute in terms of order.Before I updated to the version including this rule, I'd always written them first, like below:
What did you expect to happen?
I expected the position of
slot
andslot-scope
to be the same in this rule.What actually happened? Please include the actual, raw output from ESLint.
Since
slot-scope
is not explicitly covered, it is treated like any other custom attr, and expected to be after any bound ones.[eslint] Attribute ":class" should go before "slot-scope". (vue/attributes-order)
I can make them read at the expected positions thusly:but that feels like cheating..The text was updated successfully, but these errors were encountered: