-
-
Notifications
You must be signed in to change notification settings - Fork 681
New: Add vue/no-invalid-model-keys
rule
#1466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New: Add vue/no-invalid-model-keys
rule
#1466
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR!
The source code looks good, but I have some change requests.
Co-authored-by: Yosuke Ota <[email protected]>
Co-authored-by: Yosuke Ota <[email protected]>
Co-authored-by: Yosuke Ota <[email protected]>
Co-authored-by: Yosuke Ota <[email protected]>
Co-authored-by: Yosuke Ota <[email protected]>
Co-authored-by: Yosuke Ota <[email protected]>
Co-authored-by: Yosuke Ota <[email protected]>
@ota-meshi thanks for review and suggestions! Could you check again please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you for your contribution!
This PR adds the rule
vue/no-invalid-model-keys
which checkmodel
prop keysREF: #824