feat(no-this-in-before-router-enter): create rule #1506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
przemyslawjanpietrzak
force-pushed
the
feat/no-this-in-before-route-enter
branch
5 times, most recently
from
c283697 to
683c70a
Compare
przemyslawjanpietrzak
force-pushed
the
feat/no-this-in-before-route-enter
branch
from
683c70a to
2870d51
Compare
ota-meshi
reviewed
Jun 3, 2021
ota-meshi
approved these changes
Jun 3, 2021
| ## Rule Details | ||
|
|
||
| Bad: | ||
| ```js |
|
|
||
| ## Rule Details | ||
|
|
||
| Bad: |
There was a problem hiding this comment.
Use <eslint-code-block> like any other docs to build your docs for online demos. You can try it locally with the npm run docs:watch command.
| > This rule prevents usage this in the "beforeRouteEnter" because this is undefined there. https://router.vuejs.org/guide/advanced/navigation-guards.html#in-component-guards | ||
|
|
||
| ## Rule Details | ||
|
|
There was a problem hiding this comment.
Could you write a description of the rule here? Documents should automatically update their headers and footers with the npm run update command.
Comment on lines
57
to
60
| ## When Not To Use It | ||
|
|
||
| Give a short description of when it would be appropriate to turn off this rule. | ||
|
|
There was a problem hiding this comment.
If there is no content, delete it.
Suggested change
| ## When Not To Use It | |
| Give a short description of when it would be appropriate to turn off this rule. |
| filename: 'ValidComponent.vue', | ||
| errors: [ | ||
| { | ||
| message: rule.errorMessage |
There was a problem hiding this comment.
Would you test the location of the error, including line and column? Also, test the message as text.
Co-authored-by: Yosuke Ota <[email protected]>
Co-authored-by: Yosuke Ota <[email protected]>
Update lib/rules/no-this-in-before-route-enter.js Co-authored-by: Yosuke Ota <[email protected]> Update docs/rules/no-this-in-before-route-enter.md Co-authored-by: Yosuke Ota <[email protected]>
…yslawjanpietrzak/eslint-plugin-vue into feat/no-this-in-before-route-enter
|
@ota-meshi I applied all of your suggestions. Thanks a lot for for it, it is my first PR so it was very helpful. |
ota-meshi
approved these changes
Jun 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #1417