-
-
Notifications
You must be signed in to change notification settings - Fork 681
Add vue/no-undef-components
rule and deprecate vue/no-unregistered-components
rule
#1763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
vue/no-undef-components-in-script-setup
rulevue/no-undef-components
rule and deprecate vue/no-unregistered-components
rule
I changed this PR. So please check again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Just a docs wording suggestion.
Co-authored-by: Flo Edelmann <[email protected]>
@@ -44,8 +44,10 @@ module.exports = { | |||
'disallow using components that are not registered inside templates', | |||
categories: null, | |||
recommended: false, | |||
url: 'https://eslint.vuejs.org/rules/no-unregistered-components.html' | |||
url: 'https://eslint.vuejs.org/rules/no-unregistered-components.html', | |||
replacedBy: ['no-undef-components'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this replacedBy
needs to be outside of the doc
object:
https://eslint.org/docs/developer-guide/working-with-rules#rule-basics
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, good catch! I fixed the position in #1783.
This PR adds
vue/no-undef-components
rule and deprecatesvue/no-unregistered-components
rule .The
vue/no-undef-components
rule warns that the component used in the<template>
is not defined.close #1693