Skip to content

fix: change flat config name separator to / #2498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 13, 2024
+11 −11
Merged

fix: change flat config name separator to / #2498

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/configs/flat/base.js
View file
Original file line number Diff line number Diff line change
@@ -6,7 +6,7 @@
const globals = require('globals')
module.exports = [
{
name: 'vue:base:setup',
name: 'vue/base/setup',
plugins: {
get vue() {
return require('../../index')
@@ -18,7 +18,7 @@ module.exports = [
}
},
{
name: 'vue:base:setup-for-vue',
name: 'vue/base/setup-for-vue',
files: ['*.vue', '**/*.vue'],
plugins: {
get vue() {
2 changes: 1 addition & 1 deletion lib/configs/flat/vue2-essential.js
View file
Original file line number Diff line number Diff line change
@@ -9,7 +9,7 @@ const config = require('./base.js')
module.exports = [
...config,
{
name: 'vue:vue2-essential:rules',
name: 'vue/vue2-essential/rules',
rules: {
'vue/multi-word-component-names': 'error',
'vue/no-arrow-functions-in-watch': 'error',
2 changes: 1 addition & 1 deletion lib/configs/flat/vue2-recommended.js
View file
Original file line number Diff line number Diff line change
@@ -9,7 +9,7 @@ const config = require('./vue2-strongly-recommended.js')
module.exports = [
...config,
{
name: 'vue:vue2-recommended:rules',
name: 'vue/vue2-recommended/rules',
rules: {
'vue/attributes-order': 'warn',
'vue/component-tags-order': 'warn',
2 changes: 1 addition & 1 deletion lib/configs/flat/vue2-strongly-recommended.js
View file
Original file line number Diff line number Diff line change
@@ -9,7 +9,7 @@ const config = require('./vue2-essential.js')
module.exports = [
...config,
{
name: 'vue:vue2-strongly-recommended:rules',
name: 'vue/vue2-strongly-recommended/rules',
rules: {
'vue/attribute-hyphenation': 'warn',
'vue/component-definition-name-casing': 'warn',
2 changes: 1 addition & 1 deletion lib/configs/flat/vue3-essential.js
View file
Original file line number Diff line number Diff line change
@@ -9,7 +9,7 @@ const config = require('./base.js')
module.exports = [
...config,
{
name: 'vue:essential:rules',
name: 'vue/essential/rules',
rules: {
'vue/multi-word-component-names': 'error',
'vue/no-arrow-functions-in-watch': 'error',
2 changes: 1 addition & 1 deletion lib/configs/flat/vue3-recommended.js
View file
Original file line number Diff line number Diff line change
@@ -9,7 +9,7 @@ const config = require('./vue3-strongly-recommended.js')
module.exports = [
...config,
{
name: 'vue:recommended:rules',
name: 'vue/recommended/rules',
rules: {
'vue/attributes-order': 'warn',
'vue/component-tags-order': 'warn',
2 changes: 1 addition & 1 deletion lib/configs/flat/vue3-strongly-recommended.js
View file
Original file line number Diff line number Diff line change
@@ -9,7 +9,7 @@ const config = require('./vue3-essential.js')
module.exports = [
...config,
{
name: 'vue:strongly-recommended:rules',
name: 'vue/strongly-recommended/rules',
rules: {
'vue/attribute-hyphenation': 'warn',
'vue/component-definition-name-casing': 'warn',
6 changes: 3 additions & 3 deletions tools/update-lib-flat-configs.js
View file
Original file line number Diff line number Diff line change
@@ -58,7 +58,7 @@ function formatCategory(category) {
const globals = require('globals')
module.exports = [
{
name: 'vue:base:setup',
name: 'vue/base/setup',
plugins: {
get vue() {
return require('../../index')
@@ -70,7 +70,7 @@ module.exports = [
}
},
{
name: 'vue:base:setup-for-vue',
name: 'vue/base/setup-for-vue',
files: ['*.vue', '**/*.vue'],
plugins: {
get vue() {
@@ -99,7 +99,7 @@ const config = require('./${extendsCategoryId}.js')
module.exports = [
...config,
{
name: 'vue:${category.categoryId.replace(/^vue3-/u, '')}:rules',
name: 'vue/${category.categoryId.replace(/^vue3-/u, '')}/rules',
rules: ${formatRules(category.rules, category.categoryId)},
}
]

Unchanged files with check annotations Beta

View file
lib/index.js
vue: require('./processor')
},
environments: {
// TODO Remove in the next major version

Check warning on line 280 in lib/index.js

GitHub Actions / Lint 

Unexpected 'todo' comment: 'TODO Remove in the next major version'
/** @deprecated */
'setup-compiler-macros': {
globals: {
View file
lib/rules/valid-define-options.js
type: 'problem',
docs: {
description: 'enforce valid `defineOptions` compiler macro',
// TODO Switch in the next major version

Check warning on line 15 in lib/rules/valid-define-options.js

GitHub Actions / Lint 

Unexpected 'todo' comment: 'TODO Switch in the next major version'
// categories: ['vue3-essential', 'vue2-essential'],
categories: undefined,
url: 'https://eslint.vuejs.org/rules/valid-define-options.html'