Skip to content

feat: add vue/no-import-compiler-macros rule #2684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 5, 2025

Conversation

waynzh
Copy link
Member

@waynzh waynzh commented Feb 13, 2025

resolve #2437

Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this rule! 🙂

@waynzh waynzh force-pushed the no-import-compiler-macros branch from 3562234 to 3c7654d Compare February 20, 2025 11:47
@waynzh waynzh requested a review from FloEdelmann February 20, 2025 11:50
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks 🙂

@FloEdelmann FloEdelmann changed the title feat: add no-import-compiler-macros rule feat: add vue/no-import-compiler-macros rule Feb 20, 2025
@waynzh waynzh requested a review from ota-meshi March 3, 2025 13:09
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@ota-meshi ota-meshi merged commit ddfd676 into master Mar 5, 2025
12 checks passed
@ota-meshi ota-meshi deleted the no-import-compiler-macros branch March 5, 2025 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

disallow importing macros: defineProps etc
3 participants