New: vue/script-indent rule (fixes #118) #309
Conversation
|
I have imported |
|
Please resolve conflicts in your spare time :) I'll try to review it in the next few days |
# Conflicts: # lib/rules/html-indent.js # tests/lib/rules/html-indent.js
# Conflicts: # README.md
# Conflicts: # .eslintignore # README.md
| const baseObj = JSON.parse(/^<!--(.+?)-->/.exec(code0)[1]) | ||
| return Object.assign(baseObj, { code, filename }) | ||
| }) | ||
| const invalid = valid |
There was a problem hiding this comment.
It's hard to read and know which fixture is good, or not. You're detecting them here, but I think it would be muuuch easier to just add another comment or put valid fixtures in valid directory and so on. Then you wouldn't need to do any confusing magic here. Or am I'm missing something? (It's very possible :D)
There was a problem hiding this comment.
I'll add comments about what this does.
This addresses the code in fixtures as valid.
And this creates an invalid case from every valid case -- it removes all indentation and checks whether the rule restores all indentation or not.
There was a problem hiding this comment.
So if there are ignored lines, we can't use fixtures. And it's the reason that some tests exist on outside of fixtures.
There was a problem hiding this comment.
I added comments.
To realize invalid sub-directory, it needs a DSL to specify expected indentation for each line. Indeed it would be useful, but I avoided it for my time.
There was a problem hiding this comment.
Fine, now it's much easier to understand. Thank you for explanation and comments :)
Fixes #118.
This PR adds
vue/script-indentrule.The
vue/script-indentrule is sharing all logic withvue/html-indentrule. The shared logic is atlib/utils/indent-common.js.Also, this PR refactored the tests of
vue/html-indentrule. New tests load files fromtests/fixtures/html-indent/then use it as valid cases. And it makes invalid tests from the valid tests automatically -- removing all indentation and checking warning/fixing for correct indentation.Similarly, the tests of
vue/script-indentrule are intests/fixtures/script-indent/.