Skip to content

[Fixes #315] Report missing prop types only for assigned arrays and objects #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 6, 2018
Merged

[Fixes #315] Report missing prop types only for assigned arrays and objects #318

merged 1 commit into from
Jan 6, 2018

Conversation

michalsnik
Copy link
Member

@michalsnik michalsnik requested a review from mysticatea January 1, 2018 23:29
mysticatea
mysticatea approved these changes Jan 2, 2018
View reviewed changes
Copy link
Member

@mysticatea mysticatea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

mysticatea
mysticatea suggested changes Jan 2, 2018
View reviewed changes
Copy link
Member

@mysticatea mysticatea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I realized that the new test cases are invalid.

tests/lib/rules/require-prop-types.js
{
filename: 'test.vue',
code: `
export default {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's needed to enclose by <script> element.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, it's not needed. It works good as is :) It's enough to put export default { and .vue filename :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I got it. I had misunderstood that the tests are using vue-eslint-parser.

@michalsnik michalsnik merged commit 8ea98e7 into master Jan 6, 2018
@michalsnik michalsnik deleted the fix-false-positive-in-require-prop-types branch January 6, 2018 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mysticatea mysticatea mysticatea approved these changes

Assignees
No one assigned
Labels
semver-patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michalsnik @mysticatea