Docs: update README.md #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalsnik
reviewed
Feb 21, 2018
README.md
Outdated
| @@ -234,14 +236,20 @@ If you already use other parser (e.g. `"parser": "babel-eslint"`), please move i | |||
|
|
|||
| The `vue-eslint-parser` uses the parser which is set by `parserOptions.parser` to parse scripts. | |||
|
|
|||
| ### Can my javascript code have increased indentation? | |||
| ### Why don't work on `.vue` file? | |||
There was a problem hiding this comment.
Perhaps this sounds a bit more natural:
Why doesn't it work on .vue file?
michalsnik
reviewed
Feb 21, 2018
README.md
Outdated
|
|
||
| It depends on the version of eslint you're using. | ||
| 1. Make sure you don't have `eslint-plugin-html` in your config. The `eslint-plugin-html` extract the inside of `<script>` tags from the source code, but `eslint-vue-plugin` requires `<script>` tags and `<template>` tags in order to find script and template. |
There was a problem hiding this comment.
extracts the content from <script> tags, but ...in order to distinguish template and script in single file components
michalsnik
reviewed
Feb 21, 2018
README.md
Outdated
|
|
||
| You can however use [indent-legacy](https://eslint.org/docs/rules/indent-legacy) rule instead. | ||
| More informations [here](https://eslint.org/docs/user-guide/migrating-to-4.0.0#indent-rewrite). | ||
| 2. Make sure your tool does linting for `.vue` files. |
There was a problem hiding this comment.
Perhaps: Make sure your tool is set to lint .vue files.
michalsnik
reviewed
Feb 21, 2018
README.md
Outdated
| More informations [here](https://eslint.org/docs/user-guide/migrating-to-4.0.0#indent-rewrite). | ||
| 2. Make sure your tool does linting for `.vue` files. | ||
| - CLI targets only `.js` files by default. You have to specify additional extensions by `--ext` option or glob patterns. E.g. `eslint "src/**/*.{js,vue}"` or `eslint src --ext .vue`. | ||
| - VSCode targets only JavaScript or HTML files by default. You have to add `{"autoFix": true, "language": "vue"}` into `eslint.validate` entry. |
There was a problem hiding this comment.
autoFix is not necessary I guess :)
It's enought to just add another language to array, like so:
"eslint.validate": [
"javascript",
"javascriptreact",
"vue",
"vue-html"
],
There was a problem hiding this comment.
It's necessary because vscode-eslint does not fix code on additional file types by default. (microsoft/vscode-eslint#185)
|
Thank you for the correction! I updated this PR. |
michalsnik
approved these changes
Feb 24, 2018
michalsnik
pushed a commit
that referenced
this pull request
Feb 24, 2018
* Docs: update README.md * fix grammer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds two things and removes one thing:
eslint --fixandbabel-eslint.eslint-plugin-html.vue/script-indent.