Skip to content

Changing console.assert to node assert #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2017
Merged

Changing console.assert to node assert #40

merged 1 commit into from
Jun 20, 2017

Conversation

gabrielboliveira
Copy link
Contributor

Related to #35. Tested on Atom editor and on CLI, fixes Atom issue and no changes on CLI.

Copy link
Member

@michalsnik michalsnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for changing this @gabrielboliveira ! I didn't like the initial console.asserts too, now it should work fine indeed :)

@michalsnik michalsnik merged commit b71c7a3 into vuejs:master Jun 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants