Fix: no-invalid-template-root has false positive about empty templates (fixes #41)
#44
Conversation
| { | ||
| filename: 'test.vue', | ||
| code: '<template>\n</template>', | ||
| errors: ['The template root requires exactly one element.'] | ||
| code: '<template>\n</template>' |
There was a problem hiding this comment.
Empty template seems also bad since users can simply skip the template section. I would like to see exactly one element warning back.
There was a problem hiding this comment.
I think template root should be empty only if it is an external template reference.
Related: vuejs/vetur#272
There was a problem hiding this comment.
@HerringtonDarkholme Could you know where the document about <template src="foo.html"> is? User guide seems to not say about <template src="foo.html">. Also HTML spec does not have the src attribute.
There was a problem hiding this comment.
It is listed in vue-loader's spec. http://vue-loader.vuejs.org/en/start/spec.html#src-imports
There was a problem hiding this comment.
@HerringtonDarkholme Thank you!
| code: '<template><slot></slot></template>', | ||
| errors: ["The template root disallows '<slot>' elements."] | ||
| code: '<template src="foo.html">abc</template>', | ||
| errors: ["The template root which has 'src' attribute requires empty."] |
There was a problem hiding this comment.
What do you think about amending this message to be: The template root with 'src' attribute is required to be empty.
| @@ -6,16 +6,21 @@ This rule checks whether every template root is valid. | |||
|
|
|||
| This rule reports the template root if the following cases: | |||
There was a problem hiding this comment.
I know it's out of the scope of this task, but if you're already on it maybe you could change if to in. We can also do a separate PR with copy updates though, so whatever..
|
Thank you for corrections! |
Fixes #41.
This PR removes the warnings about empty templates.